Conversation
neSpecc
approved these changes
Apr 15, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates notification templates so Telegram, Slack, and Loop include the triggering repetitionId in event links (matching the URL shape already used by the email channel for repetition-specific navigation).
Changes:
- Telegram/Loop event templates now append
/:repetitionId/overviewwhenrepetitionIdis present. - Slack
getEventUrl()now accepts an optionalrepetitionIdand composes repetition-specific URLs; Slack event template passes it through. - Adds/extends unit tests to validate URL composition for Telegram, Loop, and Slack.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| workers/telegram/src/templates/event.ts | Adds repetition-aware event URL construction. |
| workers/telegram/tests/provider.test.ts | Adds coverage asserting repetition-aware URLs in rendered Telegram messages. |
| workers/loop/src/templates/event.ts | Adds repetition-aware event URL construction. |
| workers/loop/tests/provider.test.ts | Adds coverage asserting repetition-aware URLs in rendered Loop messages. |
| workers/slack/src/templates/utils.ts | Extends getEventUrl() to optionally include repetitionId + /overview. |
| workers/slack/src/templates/event.ts | Passes eventInfo.repetitionId into getEventUrl(). |
| workers/slack/tests/utils.test.ts | Adds unit tests for getEventUrl() repetition behavior. |
| package.json | Bumps package version from 0.1.3 to 0.1.4. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
FeironoX5
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Notification links in Telegram, Slack, and Loop were pointing to the original event (
/event/:eventId/) instead of the specific repetition that triggered the notification. The email channel had this correct already.Changes
telegram/src/templates/event.ts— appendsrepetitionId/overviewto the event URL whenrepetitionIdis presentloop/src/templates/event.ts— same fixslack/src/templates/utils.ts—getEventUrl()now accepts an optionalrepetitionIdand includes it in the URLslack/src/templates/event.ts— passeseventInfo.repetitionIdtogetEventUrl()URL format:
/project/:projectId/event/:eventId/:repetitionId/overview(matches the email template and Garage router expectation).