Skip to content

fix: include repetitionId in notification event URLs for Telegram, Slack, and Loop#544

Merged
Dobrunia merged 2 commits intomasterfrom
fix/notification-event-url-repetition-id
Apr 16, 2026
Merged

fix: include repetitionId in notification event URLs for Telegram, Slack, and Loop#544
Dobrunia merged 2 commits intomasterfrom
fix/notification-event-url-repetition-id

Conversation

@Dobrunia
Copy link
Copy Markdown
Member

Problem

Notification links in Telegram, Slack, and Loop were pointing to the original event (/event/:eventId/) instead of the specific repetition that triggered the notification. The email channel had this correct already.

Changes

  • telegram/src/templates/event.ts — appends repetitionId/overview to the event URL when repetitionId is present
  • loop/src/templates/event.ts — same fix
  • slack/src/templates/utils.tsgetEventUrl() now accepts an optional repetitionId and includes it in the URL
  • slack/src/templates/event.ts — passes eventInfo.repetitionId to getEventUrl()

URL format: /project/:projectId/event/:eventId/:repetitionId/overview (matches the email template and Garage router expectation).

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates notification templates so Telegram, Slack, and Loop include the triggering repetitionId in event links (matching the URL shape already used by the email channel for repetition-specific navigation).

Changes:

  • Telegram/Loop event templates now append /:repetitionId/overview when repetitionId is present.
  • Slack getEventUrl() now accepts an optional repetitionId and composes repetition-specific URLs; Slack event template passes it through.
  • Adds/extends unit tests to validate URL composition for Telegram, Loop, and Slack.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
workers/telegram/src/templates/event.ts Adds repetition-aware event URL construction.
workers/telegram/tests/provider.test.ts Adds coverage asserting repetition-aware URLs in rendered Telegram messages.
workers/loop/src/templates/event.ts Adds repetition-aware event URL construction.
workers/loop/tests/provider.test.ts Adds coverage asserting repetition-aware URLs in rendered Loop messages.
workers/slack/src/templates/utils.ts Extends getEventUrl() to optionally include repetitionId + /overview.
workers/slack/src/templates/event.ts Passes eventInfo.repetitionId into getEventUrl().
workers/slack/tests/utils.test.ts Adds unit tests for getEventUrl() repetition behavior.
package.json Bumps package version from 0.1.3 to 0.1.4.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Dobrunia Dobrunia merged commit ab8db60 into master Apr 16, 2026
5 checks passed
@Dobrunia Dobrunia deleted the fix/notification-event-url-repetition-id branch April 16, 2026 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants