fix(metrics): round Redis TimeSeries timestamps to bucket boundaries#542
Merged
pavelzotikov merged 3 commits intomasterfrom Apr 14, 2026
Merged
fix(metrics): round Redis TimeSeries timestamps to bucket boundaries#542pavelzotikov merged 3 commits intomasterfrom
pavelzotikov merged 3 commits intomasterfrom
Conversation
neSpecc
reviewed
Apr 14, 2026
neSpecc
previously approved these changes
Apr 14, 2026
e11sy
approved these changes
Apr 14, 2026
neSpecc
approved these changes
Apr 14, 2026
pavelzotikov
added a commit
that referenced
this pull request
Apr 14, 2026
* feat(workers): catch-unhandled-exceptions (#532) * feat(workers): add decorator to catch unhandled exceptions and report them to Hawk with worker type context * fix lint * Revert "fix lint" This reverts commit 7a7c0a9. * Revert "feat(workers): add decorator to catch unhandled exceptions and report them to Hawk with worker type context" This reverts commit ebb1fd7. * refactor(runner): add active worker names to HawkCatcher context * fix(): redis never throws key does not exist (#539) * fix(metrics): round Redis TimeSeries timestamps to bucket boundaries (#542) * fix(metrics): round Redis TimeSeries timestamps to bucket boundaries * refactor(metrics): extract bucketTimestampMs to utils and add unit tests * fix(metrics): replace magic number 90 with named constant --------- Co-authored-by: KoshaevEugeny <103786108+akulistus@users.noreply.github.com> Co-authored-by: e11sy <130844513+e11sy@users.noreply.github.com> Co-authored-by: Pavel Zotikov <pavelzotikov@gmail.com>
akulistus
added a commit
that referenced
this pull request
Apr 15, 2026
* feat(workers): catch-unhandled-exceptions (#532) * feat(workers): add decorator to catch unhandled exceptions and report them to Hawk with worker type context * fix lint * Revert "fix lint" This reverts commit 7a7c0a9. * Revert "feat(workers): add decorator to catch unhandled exceptions and report them to Hawk with worker type context" This reverts commit ebb1fd7. * refactor(runner): add active worker names to HawkCatcher context * fix(): redis never throws key does not exist (#539) * fix(metrics): round Redis TimeSeries timestamps to bucket boundaries (#542) * fix(metrics): round Redis TimeSeries timestamps to bucket boundaries * refactor(metrics): extract bucketTimestampMs to utils and add unit tests * fix(metrics): replace magic number 90 with named constant * feat(sentry): include message into title (#541) * feat(sentry): include message into title * fix(sentry): message is included in title if exception is missing --------- Co-authored-by: KoshaevEugeny <103786108+akulistus@users.noreply.github.com> Co-authored-by: e11sy <130844513+e11sy@users.noreply.github.com> Co-authored-by: Pavel Zotikov <pavelzotikov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use truncated UTC timestamps (start of minute/hour/day) when writing
to TS keys so ON_DUPLICATE SUM correctly accumulates events within
the same bucket instead of creating a separate sample per event.