Skip to content

Feat/events multiselect bulk actions#640

Open
Dobrunia wants to merge 6 commits intomasterfrom
feat/events-multiselect-bulk-actions
Open

Feat/events multiselect bulk actions#640
Dobrunia wants to merge 6 commits intomasterfrom
feat/events-multiselect-bulk-actions

Conversation

@Dobrunia
Copy link
Copy Markdown
Member

Summary

Introduces multi-select on the project daily events list with a bulk action bar

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unexpected change

Comment on lines +921 to +926
/**
* Max original event ids per bulkToggleEventMark request
*/
static get BULK_TOGGLE_EVENT_MARK_MAX() {
return 100;
}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

specify exact problem

Comment on lines +940 to +942
if (mark !== 'resolved' && mark !== 'ignored' && mark !== 'starred') {
throw new Error(`bulkToggleEventMark: mark must be resolved, ignored or starred, got ${mark}`);
}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validation should be on resolver level (or via graphql schema)

failedEventIds,
};
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try using updateMany

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants