Skip to content

Add tests for click_source_redirect in DocMethodsController #1854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
apoorvdarshan wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add tests for click_source_redirect in DocMethodsController #1854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a30c2bf
Add tests for click_source_redirect in DocMethodsController
apoorvdarshan Feb 18, 2026
e49b62c
Fix click_source_redirect to handle missing DocAssignment gracefully
apoorvdarshan Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/controllers/doc_methods_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ def click_method_redirect

def click_source_redirect
doc = DocMethod.find(params[:id])
sub = RepoSubscription.find_by!(user_id: params[:user_id], repo: doc.repo)
assignment = DocAssignment.find_by!(doc_method_id: doc.id, repo_subscription_id: sub.id)
sub = RepoSubscription.where(user_id: params[:user_id], repo: doc.repo).first
assignment = DocAssignment.where(doc_method_id: doc.id, repo_subscription_id: sub.id).first

if assignment&.user&.id.to_s == params[:user_id]
assignment.user.record_click!
Expand Down
15 changes: 15 additions & 0 deletions test/functional/doc_methods_controller_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,19 @@ class DocMethodsControllerTest < ActionController::TestCase
assert flash[:notice].eql? "Bad url, if this problem persists please open an issue github.com/codetriage/codetriage"
assert_redirected_to :root
end

test "click_source_redirect with a DocAssignment redirects to the github source url" do
DocAssignment.create(doc_method_id: @triage_doc.id, repo_subscription_id: @repo_sub.id)

get :click_source_redirect, params: {id: @triage_doc.id, user_id: @user.id}

assert_redirected_to @triage_doc.to_github
end

test "click_source_redirect without any DocAssignment returns to root and displays an error" do
get :click_source_redirect, params: {id: @triage_doc.id, user_id: @user.id}

assert flash[:notice].eql? "Bad url, if this problem persists please open an issue github.com/codetriage/codetriage"
assert_redirected_to :root
end
end