feat(argocd): secure password input and optional deploy-dc-config params#439
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new oms beta install argocd-repo-secret command to create/update ArgoCD repository secrets (Helm OCI or Git), backed by a rendered Kubernetes Secret manifest and applied via the existing Kubernetes apply helpers.
Changes:
- Introduces a generic ArgoCD repo Secret template and an
internal/installerhelper to render/apply it. - Adds a new Cobra subcommand under
oms beta installto collect flags + resolve password and apply the secret. - Adds Ginkgo tests and user-facing docs for the new command.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/installer/manifests/argocd/repo-secret.yaml.tpl | New generic ArgoCD repository Secret YAML template (parameterized). |
| internal/installer/argocd_repo_secret.go | New installer that renders the template and applies the Secret to the cluster. |
| internal/installer/argocd_repo_secret_test.go | Tests for creating/updating the repo Secret via a fake Kubernetes client. |
| docs/oms_beta_install.md | Adds the new subcommand to the beta install docs index. |
| docs/oms_beta_install_argocd-repo-secret.md | New documentation page for the command usage/options/examples. |
| cli/cmd/beta_install.go | Wires the new subcommand into oms beta install. |
| cli/cmd/argocd_repo_secret.go | New Cobra command implementation and password resolution logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
9bb9f6e to
0c87812
Compare
schrodit
reviewed
May 26, 2026
schrodit
reviewed
May 27, 2026
Member
schrodit
left a comment
There was a problem hiding this comment.
mostly fine just some clarification missing
bachgg
approved these changes
May 27, 2026
Contributor
bachgg
left a comment
There was a problem hiding this comment.
General logic change looks good to me
Signed-off-by: Jcing95 <23337729+Jcing95@users.noreply.github.com>
Hardcode all other values for the codesphere-helm-repo secret. The repo URL defaults to ghcr.io/codesphere-cloud/charts but can be overridden for mirrors. Username defaults to CodesphereBot.
Signed-off-by: Jcing95 <23337729+Jcing95@users.noreply.github.com>
206330b to
88cf040
Compare
schrodit
approved these changes
May 28, 2026
OliverTrautvetter
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OMS_REGISTRY_PASSWORDenv var or promptedinteractively (removes
--registry-passwordflag)OMS_GIT_PASSWORDenv var; git repo credentialis skipped when not set (removes
--git-passwordflag)--dc-idis now optional: local cluster secret is skipped when not provided--registry-urlflag (defaults toghcr.io/codesphere-cloud/charts)argocd-repo-secretsubcommand (functionality covered by--deploy-dc-config)NewArgoCDfailure path for better debuggingUsage
Breaking Changes
--registry-passwordflag removed (useOMS_REGISTRY_PASSWORDenv var instead)--git-passwordflag removed (useOMS_GIT_PASSWORDenv var instead)oms beta install argocd-repo-secretsubcommand removed