Read only [tool.codespell] from TOML config#3975
Merged
larsoner merged 1 commit intoJul 15, 2026
Merged
Conversation
Passing every child of [tool] to ConfigParser made unrelated arrays of tables crash option parsing. Extract only [tool.codespell], reject a non-table codespell section through the existing config error path, and cover both cases with regression tests. Fixes codespell-project#3969
DimitriPapadopoulos
approved these changes
Jul 15, 2026
|
Thanks for the fix! I just hit this today in argon2-cffi-bindings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3969.
parse_options()passed every direct child of[tool]toConfigParser, so an unrelated array of tables such as[[tool.dynamic-metadata]]raisedAttributeError. It now reads only[tool.codespell]; if that section is itself an array, codespell exits through its existing config-error path instead of showing a traceback.Regression tests cover sibling arrays for both explicit and automatic
pyproject.tomlloading, plus the malformed-section case.