Issue 5 about us/committee page #57
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a basic committee model, implementation of the enum may be different to what is desired so can easily be redone. Migrations haven't been made yet because if the issue I mentioned on discord.
- Increase title size to text-5xl/6xl for better prominence - Change underline color from gray to white to match design - Apply pixelated font (jersey10) to paragraph text - Replace text placeholder with ImageIcon component - Add second paragraph content to match design spec - Improve responsive sizing and spacing
- Add "About Us" section with styled title, underline, and content - Implement "Our Committee" section with full-width layout - Add committee member cards with portrait frames - Update color scheme to match design: * About Us title: #9B9BDE (light purple) * Underline: #5E5ECC (blue/purple) * Image placeholder: #C5C5E8 (light purple) * Main background: #090A19 (dark navy) * Committee section: #1B1F4C (purple-navy) - Make committee section full-width with flat edges - Increase portrait frame size to 180x185px - Add proper spacing between title and portraits - Style committee member names and roles with badges
- Revised the Committee model's role attribute to actually work now, turning it into a CharField with the roles as choices. - Added a __str__ method for the Committee model, where a committee object is represented by the name of its connected member object - Made all migrations for the Committee Model - Registered the model on the admin.py file, it seems fully functional on the admin dashboard
- Fixed name display format and text alignment (left-aligned) - Fixed background colors (#1B1F4C) with proper text wrapping - Fixed alignment between portraits and text labels
…to issue-5-About_us/committee_page
- Changed navbar positioning from sticky to fixed - Added left-0 right-0 to anchor navbar to viewport edges - Added z-50 to ensure navbar stays above other content - Added pt-24 padding to content wrapper to prevent content from going behind fixed navbar - Removed unnecessary fragment wrapper in navbar component
- Added a get_member() function to the Committee model which returns the object's corresponding member object - Added CommitteeAPIView which retrieves the list of members that are on the committee, in a specific order - Added this view to the committee page URL at 'about/' - Created useCommittee hook which fetches the response from the CommitteeAPIView and has appropriate error handling - Modified the about page to use this hook and dynamically use the response to display the committee members, with appropriate error handling
This reverts commit 964b84a.
- Gave the Navbar a z-index of 100 so it is now fully up to date with main
- Made two migrations to the Committee Model, setting on_delete to CASCADE for the id field and setting unique to True for the role field. - Made a series of tests for the Committee model
- Undid the removal of game_dev_club_logo.svg, next.svg and vercel.svg from client/public - Undid a change to CORS_ALLOWED_ORIGINS in the settings.py file
-Replaced the placeholder ImageIcon used for the committee portraits with Images sourced by their profile_picture attribute
- Replaced the topRow and bottomRow types with arrays of type ApiMember, imported from the useCommittee hook, rather than an unsafe any[] type. - Did formatting for prettier and flake8 (not fully done for flake8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Change Form
Other Information
There a definitely some small refinements that still need to be done, but other than that all the code is there. Notably there's probably some changes I could make to the error handling for the hook, and some of the frontend, but I don't know exactly and it would be great to get more feedback.
Related issue