generated from codersforcauses/django-nextjs-template
-
Notifications
You must be signed in to change notification settings - Fork 3
Issue 49 games showcase page #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bilibilistack
wants to merge
96
commits into
main
Choose a base branch
from
issue-49-Games_Showcase_Page
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+866
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dersforcauses/game-dev into issue-7-Individual_game_pages This because my branch and the 'origin/issue-7-Individual_game_pages' have diverged
…dersforcauses/game-dev into issue-7-Individual_game_pages Fixed issue with the server side models.py, migrated the two new models games and events
…ternal image domains for better asset management
….io account the value is added
…ignment and spacing
…dersforcauses/game-dev into issue-7-Individual_game_pages-backend Pulling any changes from issue-7-Individual_game_pages
…ages-backend Add backend changes of Itch Emed
…g and layout responsive
… field and upload location, events foregein key can be empty or set to empty if event is removed, if isItch is true then hostURL is itch.io game id 7 digit
…, contributors, and embed Itch.io game
…st ItchEmbed component styling
…dering and improve component structure
…e Games via /admin/
…aring game data for frontend
…e page as data is from useGames hook
…all games we query specific games by their id from the frontend
…ous notes when building component.
…umbnail, and rename description to game_description
… URL and handle game cover thumbnail logic
…ness and update component structure
…tor and add migration for renaming
…t was overwritten with the itchEmbedID. Updated the database schema to have both hostURL and itchEmbedID so that both the Host Site field on the page and the itch embed both work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backend
Task must have a back end issue
enhancement
New feature or request
frontend
Task must have a front end issue
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Add games showcase page, frontend and backend

Issue #49
Frontend URL: http://localhost:3000/games
Backend API URL: http://localhost:8000/api/gameshowcase/
Change Form
Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.
Other Information
[Is there anything in particular in the review that I should be aware of?]
Test procedure:
Add new or exisitng games to game showcase in the admin panel, remember to include contributor and role when add the games
Known issues:
Social media link not working because of member model is not ready.
Related issue