-
Notifications
You must be signed in to change notification settings - Fork 3
Issue 33 create the last three sections of the landing page #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Issue 33 create the last three sections of the landing page #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Off to a good start 👍
laurenpudz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! could you please also merge main into this branch and resolve conflicts so we can see what it looks like with the first sections of the landing page above it. Thanks!
client/src/pages/index.tsx
Outdated
| id: 1, | ||
| title: "Summer 2026 Game Jam", | ||
| time: "Monday 24th Oct 11:00am–4:00pm", | ||
| image: "/placeholder.png", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please change this and the image fields on lines 180 and 186 to the already existing landing_placeholder for consistency.
client/src/pages/index.tsx
Outdated
| id: 1, | ||
| title: "Cool Game", | ||
| description: "Cool game is a game about being cool.", | ||
| image: "/placeholder.png", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please also change this, line 201 and line 207 to landing_placeholder
| <Image | ||
| src={game.image} | ||
| alt={game.title} | ||
| width={340} | ||
| height={195} | ||
| /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <div className="flex h-44 w-full items-center justify-center rounded-lg bg-muted-foreground"> | ||
| <Image | ||
| src={event.image} | ||
| alt={event.title} | ||
| width={60} | ||
| height={60} | ||
| /> | ||
| </div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You only need the image here. You don't need to make the image small and center it in a box, instead, please just make the image the size that the box currently is, similar to what you've done with the game images. Please also make sure the images corners are rounded.

Implemented the last three sections of the Landing Page.
Added upcoming Events, featured Member Creations.
Basic layout and styling in Tailwind completed.
Change Form
Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.
Related issue