Issue 8 individual art pages #41
Conversation
…/game-dev into issue-8/art-page
…flict Issue 8 resolve merge conflict
- Updated migration files formatting - Updated artwork pages and components - Updated go-back-button component - Updated styles and Tailwind config - Updated serializers
…emove django-filter dependency
- Remove discord_url and instagram_url from Member model - Remove social media fields from ArtContributor model - Delete incorrect migration 0007 (social links on ArtContributor) - Update ArtContributorSerializer to remove social media field references - Change unique_together to UniqueConstraint (modern Django approach) - Add default=True to Art.active field - Keep ArtContributor as pure junction table (art, member, role only) This change aligns with the original schema design where social media links are managed through a separate SocialMedia table (in development on another branch). Addresses James's code review feedback.
There was a problem hiding this comment.
Thanks for the thorough review, James. I've made the following changes:
-
Removed django-filter dependency：
Deleted the DjangoFilterBackend import and related configuration from views.py
Removed django-filter==24.3 from requirements.txt -
Refactored database models：
Removed social media fields (discord_url, instagram_url) from the Member model
Deleted the erroneous Migration 0007 (which attempted to add social media fields to ArtContributor)
Kept ArtContributor as a pure association table containing only art, member, role
Updated related serializers to remove social media field references -
Simplified URL configuration：
Simplified the router configuration in urls.py as requested -
Other improvements：
Replaced unique_together with UniqueConstraint
Added default=True to Art.active
All changes have been pushed, and the code now fully conforms to the original schema design. Thank you for your careful review. During multiple rounds of modifications, I lost sight of the original design requirements and added a lot of code based on my own assumptions without consulting first. I apologize for that.
|
The latest version of the code resolved two tickets:
|
laurenpudz
left a comment
laurenpudz
left a comment
There was a problem hiding this comment.
hello!! could you please resolve the conflicts between this branch and the main branch, thanks!
|
Hey! Seems like some conflicts have cropped up since the new events page was merged into main. Please could you resolve these too! |
Change Summary
Improved responsive design and refactored artwork pages to follow Next.js best practices. Centralized mock data generation into a reusable hook and added proper error handling for empty database states.
Changes Made
ButtonGallerycomponent to use Next.jsLinkcomponent properlyuseArtworkData.tshookgetServerSidePropsto return mock data when API fails or DB is emptyChange Form
Other Information
Testing Notes:
Related issue