SANDBOX-1769 | feature: type for "disabled integrations" in the config#502
Conversation
WalkthroughAdded a new optional Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
We want to be able to control the integrations that are displayed in the UI via the ToolchainConfig, and in order to do that we need to have a field that controls which integrations are disabled. SANDBOX-1769
621221a to
bb2c83a
Compare
|
MatousJobanek
left a comment
There was a problem hiding this comment.
Thanks for changing it 👍
12ff40f
into
codeready-toolchain:master



Description
We want to be able to control the integrations that are displayed in the UI via the ToolchainConfig, and in order to do that we need to have a field that controls which integrations are enbaled and which are not.
Related PRs
Jira ticket
[SANDBOX-1769]
Checks
make generatetarget? yes/noYes.
make generatechange anything in other projects (host-operator, member-operator)? yes/noYes.
resources/setup/roles/host.yamlin the sandbox-sre repositoryPROJECTfile: https://github.com/codeready-toolchain/host-operator/blob/master/PROJECTCSVfile: https://github.com/codeready-toolchain/host-operator/blob/master/config/manifests/bases/host-operator.clusterserviceversion.yamlIt is not a new CRD, but rather a change in an existing one.
Will do as soon as I open them
Summary by CodeRabbit