Repository navigation
fix(meta-fetcher): strip HTML comments before parsing meta tags (#389) - #390
Merged
Merged
Conversation
…rcops#389) Commented-out tags in HTML were parsed as active metadata because the extraction regexes ran over raw HTML. Strip comments first so that commented-out <title>, <meta>, and <link> tags no longer shadow or overwrite their live counterparts.
anurag629
approved these changes
Nov 3, 2026
anurag629
added
the
codercops-accepted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
description
commented-out html tags were being parsed as active metadata because the extraction regexes ran over raw html. strip html comments before parsing to ensure commented-out
<title>,<meta>, and<link>tags do not override or interfere with active metadata.description
closes #389
how i tested this
npx vitest run tests/lib/meta-fetcher.test.ts(53 passed)git diff --check(passed)upstream/devcontains only the two intended files.ai assistance
none
type of change
screenshots
not applicable. this is a parser bug fix with no visual changes.
checklist
devnpm run checkpassesnpm run testpassesnpm run dev