Repository navigation
test: keep the unlinked qualifiers page test inside October - #141
Merged
Merged
Conversation
GET /leaderboard only lists qualifiers who haven't linked GitHub while the program runs. The test used the real clock, so once October 2026 ended it started failing on develop and on every PR. It now pins Date to the existing 'during' timestamp.
10 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
GET /leaderboardonly lists qualifiers who haven't linked GitHub while the program is running. The "names qualifying unlinked members when linking is enabled" test intest/page.test.tsused the real clock, so once October 2026 ended it started failing ondevelopand on every open PR (#140 hit it). The test now pinsDateto the file's existingduringtimestamp (Oct 12) and restores the real clock when it finishes.How I tested this
npm run typecheckis clean andnpm testpasses all 412 tests. The test fails ondeveloptoday and passes with this change.