Repository navigation
fix: give leaderboard Card links accessible names - #106
Merged
anurag629 merged 1 commit intoOct 28, 2026
Merged
Conversation
anurag629
approved these changes
Oct 28, 2026
anurag629
left a comment
Member
There was a problem hiding this comment.
Thanks @srujankaleru2007, nice and tight. Typecheck and all 386 tests pass on top of develop, and every Card link's name now says whose card it opens while the visible "Card" stays part of it.
Member
|
Hey @srujankaleru2007, thanks for all your PRs this month! If you haven't yet, come join our Discord (https://discord.gg/mpGdJyjaRQ) and run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Give every leaderboard Card link a person-specific accessible name by adding
aria-label="<login>'s share card", matching its existing title. The visible text remainsCard.Add a regression test covering all four contributors' links, including their labels, destinations, and visible Card text.
Closes #95
How I tested this
npm run typecheckpassed.npm testpassed: 15 test files, 386 tests.git diff --checkpassed.AI assistance
Used OpenAI Codex to implement the aria-label change, add the regression test, and run validation.
Checklist
npm run typecheckandnpm testpasstest/