Skip to content

fix: give leaderboard Card links accessible names - #106

Merged
anurag629 merged 1 commit into
codercops:developfrom
srujankaleru2007:issue-95-card-accessible-name
Oct 28, 2026
Merged

anurag629 merged 1 commit into
codercops:developfrom
srujankaleru2007:issue-95-card-accessible-name

Conversation

@srujankaleru2007

@srujankaleru2007 srujankaleru2007 commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

What does this change?

Give every leaderboard Card link a person-specific accessible name by adding aria-label="<login>'s share card", matching its existing title. The visible text remains Card.

Add a regression test covering all four contributors' links, including their labels, destinations, and visible Card text.

Closes #95

How I tested this

  • Confirmed the new regression test fails against the original implementation because all four links lack an aria-label.
  • npm run typecheck passed.
  • npm test passed: 15 test files, 386 tests.
  • git diff --check passed.

AI assistance

Used OpenAI Codex to implement the aria-label change, add the regression test, and run validation.

Checklist

  • I was assigned the linked issue
  • npm run typecheck and npm test pass
  • New behavior has a test in test/
  • For a bug fix: the new test fails without my change
  • No tokens or secrets in the diff

@anurag629 anurag629 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @srujankaleru2007, nice and tight. Typecheck and all 386 tests pass on top of develop, and every Card link's name now says whose card it opens while the visible "Card" stays part of it.

@anurag629 anurag629 added the hacktoberfest-accepted PR counts for Hacktoberfest label Oct 28, 2026
@anurag629
anurag629 merged commit dba2c2a into codercops:develop Oct 28, 2026
4 of 5 checks passed
@anurag629

Copy link
Copy Markdown
Member

Hey @srujankaleru2007, thanks for all your PRs this month! If you haven't yet, come join our Discord (https://discord.gg/mpGdJyjaRQ) and run /link there to connect your GitHub. That gives you the Top Contributor role for your 5+ merged PRs, and your merges show up with your name in the shoutouts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted PR counts for Hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Every Card link on the leaderboard page is just "Card" to a screen reader

2 participants