Repository navigation
release: 1.1.1 fixes, and the first trusted publish of cli, ingest and the stores - #561
Merged
Merged
Conversation
* fix(server): honor HTTP-date Retry-After values * test(server): cover HTTP-date Retry-After handling * docs(server): document HTTP-date Retry-After * chore(server): add Retry-After changeset
…check off (#520) (#535) verifyWebhook() read toleranceSec without checking it. With NaN the age comparison is never true, and with Infinity it can never be, so a stale signature passed. It now throws a RangeError unless toleranceSec is a whole number of seconds, 0 or more, before anything else is checked. The default of 300 seconds and 0 work as before. Co-authored-by: Saif Ullah jafri <saifullahjafri@Saifs-MacBook-Air.local> Co-authored-by: Anurag Verma <78868769+anurag629@users.noreply.github.com>
Co-authored-by: Anurag Verma <78868769+anurag629@users.noreply.github.com>
sync: production into dev
* fix(widget): validate script enum attributes * test(widget): cover script enum values * docs(widget): document script enum defaults * chore(widget): add script enum validation changeset * refactor(widget): use parsed script mode directly * test(widget): safely inspect optional theme config --------- Co-authored-by: Anurag Verma <78868769+anurag629@users.noreply.github.com>
Co-authored-by: Anurag Verma <78868769+anurag629@users.noreply.github.com>
* fix(widget): ignore invalid consent attributes * fix(widget): fail closed on invalid consent values --------- Co-authored-by: Anurag Verma <78868769+anurag629@users.noreply.github.com>
Co-authored-by: Anurag Verma <78868769+anurag629@users.noreply.github.com>
…iring at once when out of range (#541) (#545) A delay past what setTimeout holds (2,147,483,647 ms), NaN, a negative number or Infinity made autoOpen open the chat, and the welcome bubble show, as soon as the page loaded. A new timerDelay() keeps a valid delay, clamps a longer one to the maximum and has none for NaN, a negative number or a non-number. autoOpen with no delay doesn't auto-open, and the bubble falls back to 3000 ms. Co-authored-by: Saif Ullah jafri <saifullahjafri@Saifs-MacBook-Air.local> Co-authored-by: Anurag Verma <78868769+anurag629@users.noreply.github.com>
…557) parseRetryAfter only tries Date.parse on values with letters; a negative number is ignored. Date.parse read -1 and '1 2' as past dates, so webhooks retried at once.
…low (#558) Trusted publishing is set up for the seven; their private flags come off, so the next release publishes cli 0.3.0, ingest 0.2.0, the stores 0.3.0 and upstash-vector 0.2.0 with provenance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch fixes since 1.1.0, plus the first publish of the seven packages through the release workflow (#558). The version PR this opens gives core, server and widget
1.1.1. On merge it publishes them, along with cli 0.3.0, ingest 0.2.0, the four stores 0.3.0 and store-upstash-vector 0.2.0, all with provenance.Fixes:
data-auto-openpast the timer limit no longer opens at once (fix(widget): validate auto-open delay range #533), and neither doautoOpenandwelcomeBubble.delayfrominit()(fix(widget): keep autoOpen and welcomeBubble.delay from init() from firing at once when out of range #545)data-wait-for-consentwarns and keeps waiting (fix(widget): ignore invalid consent attributes #539)maxMessages: 0or an invalid value no longer saves everything (Widget: validate maxMessages before saving conversation history #548)containerselector gets a clear error (fix(widget): report invalid container selectors #549)Retry-After(fix(server): honor HTTP-date Retry-After values #531) and no longer read-1as a past date (fix(server): a webhook Retry-After of -1 waits, not retries at once #557), andverifyWebhookrejects atoleranceSecthat would switch the age check off (fix(server): reject a toleranceSec that would switch the webhook age check off #535)Checked on these commits: