Repository navigation
fix(cli): search the index set in ingest.index - #480
Merged
Merged
Conversation
anurag629
approved these changes
Oct 30, 2026
anurag629
left a comment
Member
There was a problem hiding this comment.
Thanks @prakashNalla, that's the fix, and the test checks both that search finds what ingest wrote under docs and that the embedder check runs against docs too. With current dev merged in, build, typecheck, test:coverage, lint (same as dev) and api:check pass, and the new test fails with the old line. Merging once CI is green.
Member
|
Merged, thanks @prakashNalla. |
2 tasks done
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
chatcops searchnow usesingest.indexfrom the config when--indexisn't passed, so it searches the same indexchatcops ingestbuilds. Before, it fell back to'default', said the index hadn't been built yet, and skipped the embedder check. Patch changeset for@chatcops/cli.Closes #479
How I tested this
Added a test to
packages/cli/tests/cli.test.tswithingest.index: 'docs'in the config: it ingests, then searches and checks the JSON reportsindex: 'docs', finds the pricing page, and doesn't print the "hasn't been built yet" message. It also checks that a config with another embedder now exits 2 for that index. The test fails without the change.pnpm -r buildandpnpm -r typecheck: passpnpm test: 2077 tests passed (65 skipped)pnpm lint: passesAI assistance
Claude helped me w/ understand the issue
Checklist
devpnpm -r build,pnpm testandpnpm -r typecheckpass locallypnpm changeset) if this changescore,widgetorserver