feat(gemini-module): Gemini session resume#810
feat(gemini-module): Gemini session resume#810Harsh9485 wants to merge 19 commits intocoder:mainfrom
Conversation
|
@mafredri, If I add the Gemini module but my workspace does not have Node installed, the workspace crashes. If I first don’t add the module, install Node, and then add the module in the template, Coder creates a new workspace, and again Node is not available, so the workspace crashes. In this PR: #374, the Node installation part was removed, and I don’t see any valid reason for that. |
You should just be able to use an image with node installed, or use the |
mafredri
left a comment
There was a problem hiding this comment.
The base64 encoding of env vars in the start script is a solid improvement, eliminating a class of shell injection via special characters in API keys and prompts. Adding --type gemini to the agentapi server command aligns with the codex, copilot, and cursor-cli modules.
A few things need attention before this can merge: 4 P1, 4 P2, 1 P3, 1 nit across 10 inline comments.
Hisoka: "The
--resumebranch silently eatingtask_prompton restart, the undeclared breaking change to the default folder, and the newexit 1killing Vertex AI ADC users. Each breaks an existing use case documented in the README."
Mafuuu: "The promise is broken at the default configuration.
enable_state_persistencedefaults totruewith agentapi v0.10.0, a combination the README itself says won't work."
Also: all four README code examples still show version = "3.0.0" but the PR declares v3.1.0. The registry checklist requires updating version references.
🤖 This review was generated with the help of Coder Agents.
|
I think the So can I remove that command and configure the MCP server on my own? |
… into gemini-session-resume


Description
Closes: #745
This PR adds the enable_state_persistence variable.
The session resume logic works as follows: when we run the Gemini CLI, it creates a folder with the same name as the directory where the CLI command runs. In the script, we use agentapi, which runs in the $GEMINI_START_DIRECTORY directory. So, I get the directory name and check whether it exists. If it does not exist, a new session is created.
Changes:
Type of Change
Module Information
Path:
registry/coder-labs/modules/geminiNew version:
v3.1.0Breaking change: [ ] Yes [x] No
Testing & Validation
bun test)bun fmt)Related Issues
#749
#745