feat(coder/github-upload-public-key): support custom key names#1014
Open
wadefletch wants to merge 1 commit into
Open
feat(coder/github-upload-public-key): support custom key names#1014wadefletch wants to merge 1 commit into
wadefletch wants to merge 1 commit into
Conversation
wadefletch
force-pushed
the
codex/configurable-github-key-name
branch
2 times, most recently
from
e8e8934 to
d4185fa
Compare
wadefletch
force-pushed
the
codex/configurable-github-key-name
branch
from
d4185fa to
01959ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add an optional
key_nameinput to thegithub-upload-public-keymodule so templates can give uploaded SSH keys a recognizable GitHub title. Existing users retain the current<Coder access URL> Workspacesdefault.The value follows the module's existing
templatefileand shell interpolation pattern. Tests use the existing fake GitHub server to verify both the default and custom titles sent in the upload request.Type of Change
Module Information
Path:
registry/coder/modules/github-upload-public-keyNew version:
v1.1.0Breaking change: [ ] Yes [x] No
Testing & Validation
bun test) — Docker-backed cases await CI because the local OrbStack daemon is unavailablebun fmt)terraform validate, ShellCheck, and formatting passRelated Issues
None
Generated with Codex using GPT-5.