-
Notifications
You must be signed in to change notification settings - Fork 6.5k
feat: add regex support to trusted-origins #7697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
abdulsattar
wants to merge
1
commit into
coder:main
Choose a base branch
from
abdulsattar:feat/trusted-origins-regex
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I would expect a regex like
/http:\/\/.+\.example\.com/to work but thelastIndexOfhere would cause regexes like this to fail.Would it be sufficient to allow a
*instead of allowing full regex, so one could dohttps://*.example.com?Internally we could still convert it to a regex, but from the user's perspective they only deal with
*and the rest is literal (similar to howproxy-domainis handled).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why
/http:\/\/.+\.example\.com/would faillastIndexOf?lastIndexOfhere is used only for getting the flags.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops sorry I mistyped, I meant
/http:\/\/.+\.example\.com(no trailing slash). We end up usinghttp:\/\as the pattern and.+\.example\.comas a flag, both of which are invalid. More fundamentally though, since slashes can change meaning based on context,lastIndexOfseems like a brittle approach.It might be OK in practice (I am not seeing any way this could lead to accidental exposure unless your domain consisted of only valid regex flags somehow). It would just fail to match anything and eventually the user would probably figure it out.
But ideally, if the user enters a malformed regex, we could error immediately so they can fix it, rather than accept an input that can never match anything, or we make it more lenient. Or we may not even need to allow flags at all and we could accept the pattern only? I think the only flag that would be useful is
i, and maybe we should default to case-insensitive matching anyway.But making the input a regex feels unnecessarily complicated to me anyway if our only goal is to allow any subdomain, and we have prior art with
--proxy-domain.http://*.example.comis easier to type and read as well.