Skip to content

test(adapters/linear): assert the deadline branch fires in TestRateLimitDeadlineReturnsTypedRateLimited #111

Closed

Description

@ThomasK33

Follow-up from #110 (an advisor suggestion, not a bug).

TestRateLimitDeadlineReturnsTypedRateLimited (adapters/linear/harden_capability_test.go) checks that a 429 whose backoff would end past the caller's deadline returns *linear.RateLimited. It does not check which branch produced that error. If a later retry-policy change sent the error out through a different check, the test would still pass.

Acceptance: the test also asserts that the deadline branch in adapters/linear/retry.go fired (for example, the "deadline" log line or an equivalent observable), and it fails when that branch is disabled. Keep the test free of timing assumptions, as #110 made it.

This gap existed before #110.


Generated with xum • Model: anthropic:claude-opus-5-5 • Thinking: medium

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    ready-for-agentFully specified, ready for an AFK agent

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions