Modernize gem #233
Open
Modernize gem #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thubActions Also disable coveralls for now [Coveralls] Submitting to https://coveralls.io/api/v1 Coveralls encountered an exception: OpenSSL::SSL::SSLError SSL_connect returned=1 errno=0 peeraddr=104.21.9.230:443 state=error: no protocols available
expected: ({:renderer=>:my_renderer}) (keyword arguments)
got: ({:renderer=>:my_renderer}) (options hash)
Collaborator
|
Thanks so much for this, very much appreciated. I checked the commits, looks fine. Are you still working on the MR or why did you put it in DRAFT state? Also: let me know if you are interested in collaborator access, always nice to see people getting involved. |
Contributor
Author
Yes, I'd like to polish 1 or 2 things before merging. Thank you!
Yes, sure! Thank you! |
n-rodriguez
force-pushed
the
wip/cleanup
branch
from
5499cbf to
ec529e0
Compare
n-rodriguez
force-pushed
the
wip/cleanup
branch
from
ec529e0 to
a83fc90
Compare
n-rodriguez
force-pushed
the
wip/cleanup
branch
3 times, most recently
from
2da5ede to
2ff633e
Compare
n-rodriguez
force-pushed
the
wip/cleanup
branch
from
2ff633e to
bc51e29
Compare
n-rodriguez
force-pushed
the
wip/cleanup
branch
from
9311745 to
6584ae2
Compare
n-rodriguez
force-pushed
the
wip/cleanup
branch
from
01fb58b to
044d90c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this gem will still be here in ten more years 😄
Thank you!
Note: better reviewed commit by commit
CI is green on my side : https://github.com/n-rodriguez/simple-navigation/actions