Fix release CI: bump certificatewizard poms to release version#5355
Merged
Conversation
The release-on-maven-central workflow's "Deploy Signing Wizard editor" step failed with 403 Forbidden because update-version.sh never bumped the scripts/certificatewizard poms off 8.0-SNAPSHOT. mvn deploy therefore targeted the Central *snapshots* repository, which the release job has no rights to publish to. The Game Builder editor (scripts/gamebuilder) — same out-of-reactor, own-coordinates shape — was already handled; certificatewizard was added later without the matching wiring. Mirror the gamebuilder block: rewrite the three module versions plus the cn1.version/cn1.plugin.version the editor builds against, and git add the tree before committing. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
Collaborator
Author
|
Compared 144 screenshots: 144 matched. Native Android coverage
✅ Native Android screenshot tests passed. Native Android coverage
Benchmark ResultsDetailed Performance Metrics
|
Collaborator
Author
|
Compared 135 screenshots: 135 matched. |
Collaborator
Author
|
Compared 139 screenshots: 139 matched. |
Collaborator
Author
|
Compared 216 screenshots: 216 matched. |
Collaborator
Author
|
Compared 137 screenshots: 137 matched. Benchmark Results
Build and Run Timing
Detailed Performance Metrics
|
Collaborator
Author
|
Compared 143 screenshots: 143 matched. Benchmark Results
Build and Run Timing
Detailed Performance Metrics
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Release on Maven Centralworkflow failed on tag 7.0.257 (run 29073446803). The core release, archetypes, and Game Builder editor all published fine — only the Deploy Signing Wizard editor step failed:Root cause
maven/update-version.shbumps the out-of-reactor gamebuilder poms to the release version, but has no equivalent block for the certificatewizard editor (added later without the matching wiring). So its poms stayed at8.0-SNAPSHOT;mvn deploythen routed to the Central snapshots repo, which the release job has no rights to publish to → 403.Fix
Mirror the gamebuilder handling for
scripts/certificatewizard: rewrite the three module<version>s plus the parent'scn1.version/cn1.plugin.version, andgit addthe tree before committing. Dry-run confirms all five8.0-SNAPSHOTreferences bump to the release version and none remain.Note on 7.0.257
This fixes future releases. The 7.0.257 certificatewizard artifact never made it to Central (core/archetypes/gamebuilder for 7.0.257 did). Since Central versions are immutable, backfilling it needs a separate manual deploy of just that module if 7.0.257 must be complete — happy to do that on request.
🤖 Generated with Claude Code