Skip to content

Refresh early guide screenshots and remove Theme Basics#5342

Open
shai-almog wants to merge 1 commit into
masterfrom
codex/pre-advanced-theming-screenshots
Open

Refresh early guide screenshots and remove Theme Basics#5342
shai-almog wants to merge 1 commit into
masterfrom
codex/pre-advanced-theming-screenshots

Conversation

@shai-almog

Copy link
Copy Markdown
Collaborator

Summary:

  • Remove the obsolete Theme Basics designer-tool chapter and its chapter-only images.
  • Add demo-backed generators for 27 applicable screenshots before Advanced Theming and commit the regenerated PNGs.
  • Add a developer-guide workflow gate that regenerates those screenshots and compares them to the committed files.

Local validation:

  • python3 scripts/developer-guide/validate-guide-snippets.py
  • python3 scripts/developer-guide/find_unused_images.py docs/developer-guide --allow-unused img/autocomplete.png --allow-unused img/native-theme-menu.png --allow-unused img/tabs.png
  • asciidoctor --require rouge --failure-level WARN --trace -o /tmp/developer-guide-pre-ch5.html docs/developer-guide/developer-guide.asciidoc
  • mvn -B -ntp -Dgenerate-gui-sources-done=true -Dcodename1.platform=javase -f docs/demos/pom.xml process-classes
  • scripts/developer-guide/compile-android-demo-sources.sh

Note: the screenshot profile is wired for Ubuntu/xvfb in CI. The local macOS forked AWT path aborts before screenshot generation, so I am using the PR job as the authoritative screenshot execution check and will fix any CI failure.

@shai-almog shai-almog force-pushed the codex/pre-advanced-theming-screenshots branch 3 times, most recently from 39a227c to be97f49 Compare July 6, 2026 19:25
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Cloudflare Preview

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Developer Guide build artifacts are available for download from this workflow run:

Developer Guide quality checks:

  • AsciiDoc linter: No issues found (report)
  • Vale: No alerts found (report)
  • Paragraph capitalization: No paragraph capitalization issues (report)
  • LanguageTool: No grammar matches (report)
  • Image references: No unused images detected (report)

@shai-almog shai-almog force-pushed the codex/pre-advanced-theming-screenshots branch 2 times, most recently from 79f76f3 to 187daa8 Compare July 7, 2026 01:43
@shai-almog shai-almog force-pushed the codex/pre-advanced-theming-screenshots branch from 187daa8 to 09f0fd4 Compare July 7, 2026 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant