Skip to content

Use Java 26 for JavaDoc generation and remove custom dark-mode overrides#4701

Open
liannacasper wants to merge 1 commit intomasterfrom
codex/update-javadoc-generation-to-java-26
Open

Use Java 26 for JavaDoc generation and remove custom dark-mode overrides#4701
liannacasper wants to merge 1 commit intomasterfrom
codex/update-javadoc-generation-to-java-26

Conversation

@liannacasper
Copy link
Copy Markdown
Collaborator

Motivation

  • Java 26 ships native dark-mode support for javadoc, so rely on the toolchain instead of the repository's brittle faux dark-mode overrides.
  • The website embeds generated JavaDocs, and the CI workflows that build/publish JavaDocs must use the same JDK to produce the new output.

Description

  • Prefer JDK_26_HOME (fall back to JAVA_HOME) in ./.github/scripts/build_javadocs.sh so the JavaDoc tool comes from Java 26 when available.
  • Update the JavaDoc-related GitHub Actions workflows (.github/workflows/javadocs.yml, .github/workflows/pr.yml, and .github/workflows/website-docs.yml) to install Java 26 and expose JDK_26_HOME where JavaDocs/site are built.
  • Remove the repository's custom JavaDoc dark-mode variable overrides from docs/website/assets/css/extended/cn1-javadoc-embed.css so JavaDoc's native styling and dark mode can be used unmodified.
  • The site build still embeds JavaDoc content via scripts/website/build.sh and the JavaDoc generation script; only the JDK/toolchain and CSS overrides were changed.

Testing

  • Ran a shell syntax check on the modified scripts with bash -n .github/scripts/build_javadocs.sh scripts/website/build.sh, which completed successfully.
  • Inspected the generated diffs to verify workflow JDK versions and CSS overrides were updated as intended (no runtime CI changes executed here).

Codex Task

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

Cloudflare Preview

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Generated automatically by the PR CI workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant