Use Java 26 for JavaDoc generation and remove custom dark-mode overrides#4701
Open
liannacasper wants to merge 1 commit intomasterfrom
Open
Use Java 26 for JavaDoc generation and remove custom dark-mode overrides#4701liannacasper wants to merge 1 commit intomasterfrom
liannacasper wants to merge 1 commit intomasterfrom
Conversation
Cloudflare Preview
|
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
javadoc, so rely on the toolchain instead of the repository's brittle faux dark-mode overrides.Description
JDK_26_HOME(fall back toJAVA_HOME) in./.github/scripts/build_javadocs.shso the JavaDoc tool comes from Java 26 when available..github/workflows/javadocs.yml,.github/workflows/pr.yml, and.github/workflows/website-docs.yml) to install Java 26 and exposeJDK_26_HOMEwhere JavaDocs/site are built.docs/website/assets/css/extended/cn1-javadoc-embed.cssso JavaDoc's native styling and dark mode can be used unmodified.scripts/website/build.shand the JavaDoc generation script; only the JDK/toolchain and CSS overrides were changed.Testing
bash -n .github/scripts/build_javadocs.sh scripts/website/build.sh, which completed successfully.Codex Task