Improve CN1 playground side menu dark mode, disable swipe, and add mobile responsiveness#4699
Merged
liannacasper merged 5 commits intomasterfrom Apr 4, 2026
Conversation
Cloudflare Preview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
isDesktopLayout()and keep the existingSplitPane(with the 25% editor sizing target) for desktop while switching to a tabbed container for mobile by returning aTabswithEditorandPreviewtabs.Toolbar.setEnableSideMenuSwipe(false)to prevent accidental triggering.SideNavigationPanel,PlaygroundSideCommand,PlaygroundMenuSection, etc.) to thesupportsDarkVariantlist so menu components receive dark variants.sideMenuSizeLandscapeIntandsideMenuSizeTabLandscapeInt) totheme.cssso the menu opens narrower (approximately 25% visible width) in desktop/landscape layouts.Testing
cd scripts/cn1playground && ./build.shbut the script is not executable in this environment, so the build did not run. (failed)cd scripts/cn1playground && bash build.sh, but the script invokes./mvnwwhich is not executable here, so the build did not complete. (failed)cd scripts/cn1playground && bash ./mvnw -pl common -DskipTests package, but the Maven wrapper failed to download dependencies due to network/proxy restrictions in this environment. (failed)Codex Task