Codex-generated pull request by shai-almog · Pull Request #4510 · codenameone/CodenameOne

shai-almog · 2026-02-12T02:42:14Z

Fix local notifications on iOS

github-actions · 2026-02-12T02:51:48Z

✅ Continuous Quality Report

Test & Coverage

✅ Tests: 2302 total, 0 failed, 0 skipped
📊 Line coverage: 53.00% [HTML preview] [Download]
- Lowest covered classes
  - com.codename1.ui.Display$EdtException – 0.00%
  - com.codename1.ui.plaf.CSSBorder$LinearGradient – 0.00%
  - com.codename1.util.EasyThread$InQueueRunnable – 0.00%
  - com.codename1.components.FloatingActionButton$ReleaseActionListener – 0.00%
  - com.codename1.io.Oauth2$ShowAuthenticationActionListener – 0.00%
  - com.codename1.io.Oauth2$RefreshTokenActionListener – 0.00%
  - com.codename1.util.EasyThread$RunAndWaitRunnable – 0.00%
  - com.codename1.components.ToastBar$FlushAnimationCallback – 0.00%
  - com.codename1.ui.plaf.CSSBorder$ColorStop – 0.00%
  - com.codename1.ui.ElevationComparator – 0.00%

Static Analysis

SpotBugs [HTML preview] [Download]
- ❌ ByteCodeTranslator: 97 findings (High: 2, Normal: 68, Low: 27)
  - Top findings
    - High: com/codename1/tools/translator/BytecodeMethod.java:559 – Method com.codename1.tools.translator.BytecodeMethod.findWritableFields(Set) seems to be useless (rule: UC_USELESS_VOID_METHOD)
    - High: com/codename1/tools/translator/bytecodes/TryCatch.java:75 – Write to static field com.codename1.tools.translator.bytecodes.TryCatch.hasTryCatch from instance method com.codename1.tools.translator.bytecodes.TryCatch.appendInstruction(StringBuilder, List) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
    - Normal: com/codename1/tools/translator/ByteCodeClass.java:1791 – com.codename1.tools.translator.ByteCodeClass.getBaseClassObject() may expose internal representation by returning ByteCodeClass.baseClassObject (rule: EI_EXPOSE_REP)
    - …and 94 more
- ❌ android: 412 findings (High: 24, Normal: 196, Low: 192)
  - Top findings
    - High: CodenameOne/src/com/codename1/impl/CodenameOneThread.java:48 – com.codename1.impl.CodenameOneThread.STACK_FRAME_SIZE isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    - High: com/codename1/impl/android/AndroidImplementation.java:1067 – Write to static field com.codename1.impl.android.AndroidImplementation.context from instance method com.codename1.impl.android.AndroidImplementation.setContext(Context) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
    - High: com/codename1/impl/android/AndroidImplementation.java:1268 – com.codename1.impl.android.AndroidImplementation.isDarkMode() has Boolean return type and returns explicit null (rule: NP_BOOLEAN_RETURN_NULL)
    - …and 409 more
- ❌ codenameone-maven-plugin: 480 findings (High: 1, Normal: 316, Low: 163)
  - Top findings
    - High: com/codename1/maven/AbstractCN1Mojo.java:807 – com.codename1.maven.AbstractCN1Mojo.OS isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    - Normal: com/codename1/builders/AndroidGradleBuilder.java:1018 – Dead store to googleServicesJson in com.codename1.builders.AndroidGradleBuilder.build(File, BuildRequest) (rule: DLS_DEAD_LOCAL_STORE)
    - Normal: com/codename1/builders/AndroidGradleBuilder.java:1043 – Possible null pointer dereference in com.codename1.builders.AndroidGradleBuilder.build(File, BuildRequest) due to return value of called method (rule: NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE)
    - …and 477 more
- ✅ core-unittests: 0 findings (no issues)
- ❌ ios: 125 findings (High: 4, Normal: 75, Low: 46)
  - Top findings
    - High: com/codename1/impl/ios/IOSImplementation.java:1223 – com.codename1.impl.ios.IOSImplementation.isDarkMode() has Boolean return type and returns explicit null (rule: NP_BOOLEAN_RETURN_NULL)
    - High: com/codename1/impl/ios/IOSImplementation.java:128 – com.codename1.impl.ios.IOSImplementation.nativeInstance isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    - High: com/codename1/impl/ios/IOSImplementation.java:214 – Write to static field com.codename1.impl.ios.IOSImplementation.instance from instance method com.codename1.impl.ios.IOSImplementation.init(Object) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
    - …and 122 more
✅ PMD: 0 findings (no issues) [Report archive]
✅ Checkstyle: 0 findings (no issues) [Report archive]

Generated automatically by the PR CI workflow.

shai-almog · 2026-02-12T02:57:18Z

Compared 31 screenshots: 31 matched.

Native Android coverage

📊 Line coverage: 7.27% (3697/50886 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 5.66% (18122/320185), branch 2.78% (865/31141), complexity 3.38% (1007/29752), method 5.95% (824/13850), class 9.73% (178/1829)
- Lowest covered classes
  - kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6327 lines covered)
  - kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.ClassReader – 0.00% (0/1519 lines covered)
  - kotlin.collections.kotlin.collections.CollectionsKt___CollectionsKt – 0.00% (0/1148 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.MethodWriter – 0.00% (0/923 lines covered)
  - kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/712 lines covered)
  - kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/623 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.Frame – 0.00% (0/564 lines covered)
  - kotlin.collections.kotlin.collections.ArraysKt___ArraysJvmKt – 0.00% (0/495 lines covered)
  - kotlinx.coroutines.kotlinx.coroutines.JobSupport – 0.00% (0/423 lines covered)

✅ Native Android screenshot tests passed.

Native Android coverage

📊 Line coverage: 7.27% (3697/50886 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 5.66% (18122/320185), branch 2.78% (865/31141), complexity 3.38% (1007/29752), method 5.95% (824/13850), class 9.73% (178/1829)
- Lowest covered classes
  - kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6327 lines covered)
  - kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.ClassReader – 0.00% (0/1519 lines covered)
  - kotlin.collections.kotlin.collections.CollectionsKt___CollectionsKt – 0.00% (0/1148 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.MethodWriter – 0.00% (0/923 lines covered)
  - kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/712 lines covered)
  - kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/623 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.Frame – 0.00% (0/564 lines covered)
  - kotlin.collections.kotlin.collections.ArraysKt___ArraysJvmKt – 0.00% (0/495 lines covered)
  - kotlinx.coroutines.kotlinx.coroutines.JobSupport – 0.00% (0/423 lines covered)

shai-almog · 2026-02-12T03:23:14Z

iOS screenshot updates

Compared 7 screenshots: 0 matched, 7 updated.

graphics-draw-line — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 70; JPEG preview quality 70; downscaled to 844x1835.
Full-resolution PNG saved as graphics-draw-line.png in workflow artifacts.
graphics-draw-rect — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 70; JPEG preview quality 70; downscaled to 844x1835.
Full-resolution PNG saved as graphics-draw-rect.png in workflow artifacts.
graphics-draw-round-rect — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 70; JPEG preview quality 70; downscaled to 844x1835.
Full-resolution PNG saved as graphics-draw-round-rect.png in workflow artifacts.
graphics-fill-rect — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 70; JPEG preview quality 70; downscaled to 844x1835.
Full-resolution PNG saved as graphics-fill-rect.png in workflow artifacts.
graphics-fill-round-rect — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 70; JPEG preview quality 70; downscaled to 844x1835.
Full-resolution PNG saved as graphics-fill-round-rect.png in workflow artifacts.
kotlin — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as kotlin.png in workflow artifacts.
MainActivity — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as MainActivity.png in workflow artifacts.

Benchmark Results

VM Translation Time: 460 seconds
Compilation Time: 300 seconds

Detailed Performance Metrics

Metric	Duration
Build Time Statistics
Setup & Unzip	38145 ms
Extract Extensions	21 ms
Google Services Setup	5 ms
Scan Classes	1434 ms
Extract Libs	821 ms
Inject Build Hints	44 ms
Generate Unit Tests	2 ms
Generate Stubs	1257 ms
Compile Stubs	2801 ms
Generate Icons	1290 ms
Prepare ParparVM	278 ms
ParparVM Execution	288891 ms
Post-VM Setup	434 ms
CocoaPods	8668 ms
Finalize	99 ms
Total Time	344193 msMaven Overhead : 116000 ms
CocoaPods Install (Script)	3000 ms
Simulator Boot	290000 ms
Simulator Boot (Run)	4000 ms
App Install	23000 ms
App Launch	10000 ms
Test Execution	301000 ms

Fix iOS local notification replacement and add Android native stub

e09dc03

shai-almog added the codex label Feb 12, 2026 — with ChatGPT Codex Connector

shai-almog added 8 commits February 12, 2026 05:56

Stabilize iOS notification native test counting and logging

69e8f8c

Harden iOS notification override path and screenshot diagnostics

c146cc8

Fail CN1 screenshot suite on capture errors and timeouts

99c5337

Add Java/native thread dumps on CN1 screenshot test failures

5c2e06b

Remove unsupported Thread.isDaemon call from diagnostics

610f2e2

Use CN1-compatible stack diagnostics in device runner

7d2c9e3

Fail fast on blank screenshots and add native crash dump hook

47460c3

Install iOS native signal handlers for crash diagnostics

0d59360

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Codex-generated pull request#4510

Codex-generated pull request#4510
shai-almog wants to merge 9 commits intomasterfrom
codex/add-test-for-local-notification-overwrite

shai-almog commented Feb 12, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 12, 2026 •

edited

Loading

Uh oh!

shai-almog commented Feb 12, 2026 •

edited

Loading

Uh oh!

shai-almog commented Feb 12, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

shai-almog commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Uh oh!

shai-almog commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Native Android coverage

Native Android coverage

Uh oh!

shai-almog commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS screenshot updates

Benchmark Results

Detailed Performance Metrics

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

shai-almog commented Feb 12, 2026 •

edited

Loading

github-actions bot commented Feb 12, 2026 •

edited

Loading

shai-almog commented Feb 12, 2026 •

edited

Loading

shai-almog commented Feb 12, 2026 •

edited

Loading