-
Notifications
You must be signed in to change notification settings - Fork 24
Add CONTRIBUTING.md, update and expand README.md #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CONTRIBUTING.md
Outdated
| Make your changes as discussed and commit them to your local copy. Include the | ||
| issue number somewhere in a commit message, prefixed with a `#`, eg, `#999`. | ||
| This will prompt GitHub to create a link back to the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you mention here that they should run Hugo to test their changes?
(or just point to the README)
| Please refer to the | ||
| [instructions for contributing](https://github.com/codemeta/codemeta/?tab=contributing-ov-file) | ||
| to that repository. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here could be nice to add a section on the display of crosswalks here, which requires the creation of an empty file to make the link between the crosswalk in the codemeta/codemeta repo and this one.
This section can also contain the information on logo location.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I did look at how it works but didn't notice that the file creation here was not automated.
And yes this should probably also mention adding the logos for those.
|
Global comment : this guide is super clear and detailed. |
|
If I remember correctly, a static file needs to be created with the a
description:
https://github.com/codemeta/codemeta.github.io/blob/master/content%2Fcrosswalk%2Fcargo.md
Then the automatic part is fetching the .csv from codemeta/codemeta + the
inclusion in the crosswalks index.
|
|
Pushed up a revision with that section. Let me know if I've missed or misinterpreted anything. I think I've correctly captured the specifics required re: naming and the shortcode? As an aside, there are a bunch of crosswalks in main without these files website side. |
This addresses one part of #55. Please critique any assumptions I've made. I have likely also missed stuff.