Repository navigation
Conversation
- Treat external pins as caret floors in doctor - Raise Next.js and MCP SDK security floors
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2bc8c62881
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!v || !p) return cmp(version, pin) === 0; | ||
| if (v.major !== p.major) return false; | ||
| if (p.major === 0 && v.minor !== p.minor) return false; | ||
| return cmp(version, pin) >= 0; |
There was a problem hiding this comment.
When a product resolves an external dependency to a prerelease above its floor—for example, next@16.5.0-canary.1 with a 16.4.1 pin—this comparison accepts it, so doctor reports conformance even though ^16.4.1 excludes prereleases and the policy only permits later patch and minor releases. A prerelease may be unstable or incompatible; exclude prereleases or apply actual caret-range semantics.
Useful? React with 👍 / 👎.
Summary
doctoraccept newer patch and minor releases within an external pin’s compatible major line, while keeping the pinned floor for generated products.Testing
bun run verify— passed, including lint, preset sync, typecheck, drift check, tests, build, and packed package checks.bun run template:smoke— not run.