Repository navigation
Sites: fix homepage JSON-LD, add og:type, sequential card heading levels - #191
Merged
Merged
Conversation
The homepage Organization/WebSite JSON-LD used the builder page's name
("Homepage") and no logo; it now uses the site title, logo and subtitle.
Builder and docs pages set og:type. Featured, Grid and Pricing item
titles render one level below the block title instead of always h4, and
the pricing price is a paragraph rather than a heading.
Closes #190
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #190.
An Is Agentic scan of medialit.cloud flagged these. They affect every hosted site.
logoUrl: null. They now use the site title, logo, and the site subtitle (falling back to the page description) asdescription.og:type:websiteon the layout and builder pages,articleon docs pages. Blog posts already hadarticle.titleLevel(so h3 under the default h2) instead of always<h4>, with the same look. The pricing price renders as<p>; it isn't a heading.PageCardHeadertakes an optionalas.Organization
sameAs/contactPoint/addressneed newsite.jsonfields and are left as a follow-up (noted in #190).Testing
apps/sitesvitest (68 passed, JSON-LD tests updated),page-buildervitest (60 passed), tsc on both, biome format check."name":"Smoke 137". After temporarily setting a subtitle and logo, it also showsdescriptionandlogo; settings were restored afterwards.og:typeiswebsite.h1 h2 h3×4 h2 h3×4 h2 …, with noh4.