feat: add UniqueConstraintViolationException#9979
Open
michalsn wants to merge 8 commits intocodeigniter4:4.8from
Open
feat: add UniqueConstraintViolationException#9979michalsn wants to merge 8 commits intocodeigniter4:4.8from
UniqueConstraintViolationException#9979michalsn wants to merge 8 commits intocodeigniter4:4.8from
Conversation
UniqueConstraintViolationException and getLastException()UniqueConstraintViolationException
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds:
UniqueConstraintViolationException(extendsDatabaseException), thrown on duplicate key violations across all database drivers$db->getLastException(): ?DatabaseException- whenDBDebugisfalse, exceptions are not thrown. This method provides a reliable way to inspect the type of failure, since raw error codes from$db->error()['code']differ across driversDatabaseException::getDatabaseCode(): int|string- exposes the native driver error code on the exception itself, asgetCode()is constrained tointby PHP Throwable interface and cannot carry string SQLSTATE codesgetLastException()is intentionally a transitional API. The long-term direction is to dropDBDebug = falseentirely (v5 ?), leaving exceptions as the only error signalling mechanism - consistent with how every other major PHP framework handles database errors.Checklist: