feat: Chunk array method in models#9962
Draft
patel-vansh wants to merge 5 commits intocodeigniter4:4.8from
Draft
feat: Chunk array method in models#9962patel-vansh wants to merge 5 commits intocodeigniter4:4.8from
patel-vansh wants to merge 5 commits intocodeigniter4:4.8from
Conversation
Contributor
Author
|
I guess this PR can only be merged after merging the |
Member
|
You can rebase, although I would wait for changes from #9961. Two things:
private function iterateChunks(int $size): Generator
{
if ($size <= 0) {
throw new InvalidArgumentException('$size must be a positive integer.');
}
$total = $this->builder()->countAllResults(false);
$offset = 0;
while ($offset < $total) {
$builder = clone $this->builder();
$rows = $builder->get($size, $offset);
if (! $rows) {
throw DataException::forEmptyDataset('chunk');
}
$rows = $rows->getResult($this->tempReturnType);
$offset += $size;
if ($rows === []) {
continue;
}
yield $rows;
}
}
public function chunk(int $size, Closure $userFunc)
{
foreach ($this->iterateChunks($size) as $rows) {
foreach ($rows as $row) {
if ($userFunc($row) === false) {
return;
}
}
}
}
public function chunkRows(int $size, Closure $userFunc)
{
foreach ($this->iterateChunks($size) as $rows) {
if ($userFunc($rows) === false) {
return;
}
}
} |
Contributor
Author
Member
|
@patel-vansh The mentioned PR has been merged, and the |
|
👋 Hi, @patel-vansh! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
chunkArray()method inCodeIgniter\Modelclass which allows users to get chunk as a whole instead of single rows, so that they can easily use functions likearray_column(...)inside the closure.Related to this forum thread.
Checklist: