Skip to content

refactor: remove $config in Response constructor#9956

Merged
paulbalandan merged 1 commit intocodeigniter4:4.8from
paulbalandan:response-remove-app
Feb 20, 2026
Merged

refactor: remove $config in Response constructor#9956
paulbalandan merged 1 commit intocodeigniter4:4.8from
paulbalandan:response-remove-app

Conversation

@paulbalandan
Copy link
Member

@paulbalandan paulbalandan commented Feb 17, 2026

Description
Remove unused $config in Response

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added refactor Pull requests that refactor code 4.8 PRs that target the `4.8` branch. labels Feb 17, 2026
@paulbalandan paulbalandan force-pushed the response-remove-app branch 2 times, most recently from 1879374 to 4339151 Compare February 17, 2026 18:56
@paulbalandan paulbalandan merged commit 5c78ba2 into codeigniter4:4.8 Feb 20, 2026
50 checks passed
@paulbalandan paulbalandan deleted the response-remove-app branch February 20, 2026 07:34
@paulbalandan
Copy link
Member Author

paulbalandan commented Feb 20, 2026

Thanks for the reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsn michalsn michalsn approved these changes

+1 more reviewer

@neznaika0 neznaika0 neznaika0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

4.8 PRs that target the `4.8` branch. refactor Pull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paulbalandan @michalsn @neznaika0

Comments