-
Notifications
You must be signed in to change notification settings - Fork 2k
feat: added async & persistent options to Cache Redis
#9792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.7
Are you sure you want to change the base?
Conversation
|
No tests required? Change config in https://github.com/codeigniter4/CodeIgniter4/blob/4.7/user_guide_src/source/libraries/caching.rst#redis-caching |
michalsn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PHPRedis can also support the persistent option, so we should add it there too via pconnect().
The async option should note that it is used only with Predis.
Preferably, all these new options should be mentioned here: https://codeigniter.com/user_guide/libraries/caching.html#redis-caching
We could introduce a separate configuration parameter for Predis in the config and switch to using new Redis() in the PHPRedis implementation. This would allow us to support all available options in both clients without worrying about missing or incompatible parameters. However, this change would introduce a minor BC break. Thoughts?
async & persistent options to cache predisasync & persistent options to Cache Redis
|
Added for redis handler too. I want make support Sentinel, but for next PR. Maybe separate config in that PR |
neznaika0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't use Redis, but it looks good.
|
PR #9793 for |
Description
Added config item to Redis in
Cache.Parameter:
asyncandpersistentconfig item to predis handler.persistentconfig item to redis handler.Checklist: