Repository navigation
Conversation
…eption BaseConnection::prepare() enables pretend mode while the user closure builds the query. If the closure threw, the following pretend(false) never ran, leaving the connection in pretend mode. Every later query on the same connection was then silently discarded instead of being executed, which is especially harmful in long-lived processes such as Worker Mode. Wrap the closure call in try/finally so pretend mode is always reset, and add a regression test covering the throwing closure.
carson-codeigniter4
Bot
added
needs template
This comment has been minimized.
This comment has been minimized.
carson-codeigniter4
Bot
removed
the
needs template
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the closure passed to
BaseConnection::prepare()threw an exception,pretend(false)was bypassed, leaving the connection in pretend mode. Every subsequent database write on the same connection was then silently discarded, which is particularly harmful in long-lived environments like Worker Mode.This wraps the closure call in a
try/finallyblock to ensure pretend mode is always reset, and adds a regression test covering the throwing closure.Checklist: