Skip to content

fix(Router): include routes in '*' bucket in getRegisteredControllers('*') - #10767

Closed
gr8man wants to merge 1 commit into
codeigniter4:developfrom
gr8man:fix/router-get-registered-controllers-wildcard
Closed

gr8man wants to merge 1 commit into
codeigniter4:developfrom
gr8man:fix/router-get-registered-controllers-wildcard

Conversation

@gr8man

@gr8man gr8man commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

No description provided.

…('*')

getRegisteredControllers('*') only iterated the default HTTP methods, so
controllers registered via $routes->add() or $routes->map(), which are
stored in the '*' bucket, were never returned. As a result
AutoRouterImproved could not protect those routes in
protectDefinedRoutes().

Iterate the '*' bucket as well, and skip redirect routes since they have
no controller to register.
@gr8man

gr8man commented Nov 11, 2026

Copy link
Copy Markdown
Contributor Author

Closing: this security fix is under private disclosure embargo with the security team.

@gr8man gr8man closed this Nov 11, 2026
@gr8man
gr8man deleted the fix/router-get-registered-controllers-wildcard branch November 11, 2026 23:43
@carson-codeigniter4 carson-codeigniter4 Bot added the bug Verified issues on the current code behavior or pull requests that will fix them label Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant