Repository navigation
Conversation
gr8man
approved these changes
Nov 11, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
Session::start(), when an incoming session cookie fails validation (! is_string($cookie) || preg_match('#\A' . $this->sidRegexp . '\z#', $cookie) !== 1), it is removed viaservice('superglobals')->unsetCookie($this->config->cookieName).However, if
service('request')->getCookie()was called prior to$session->start()(for example, in abeforefilter such asCSRF),Request::$globals['cookie']has already cached the cookie array. BecauseSession::start()did not updateRequest::setGlobal('cookie', ...)(unlikeSecurity::removeTokenInRequest()), subsequent calls to$request->getCookie($this->config->cookieName)continued returning the invalid session cookie value.This PR:
service('request')->setGlobal('cookie', $superglobals->getCookieArray())and resets$cookie = nullwhenSession::start()unsets an invalid session cookie.testStartUnsetsInvalidSessionCookieInSuperglobalsAndRequest()inSessionTest.Checklist: