Repository navigation
fix(HTTP): prevent false positive header matches in Cors::hasResponseHeaders() - #10731
Merged
michalsn merged 1 commit intoNov 12, 2026
Merged
Conversation
carson-codeigniter4
Bot
added
the
bug
gr8man
force-pushed
the
fix/cors-has-response-headers
branch
from
November 5, 2026 20:31
d5df9b7 to
3b1860e
Compare
michalsn
approved these changes
Nov 9, 2026
paulbalandan
approved these changes
Nov 9, 2026
gr8man
force-pushed
the
fix/cors-has-response-headers
branch
from
November 9, 2026 18:22
3b1860e to
ebaca13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cors::hasResponseHeaders()usedstr_contains()to check for exposed headers, which produced false positives when an existing header was a prefix/substring of the configured header (e.g.X-Custommatched inX-Custom-Header). It now parses the header list and performs exact, case-insensitive comparisons for each configured header.Checklist: