fix: specify parameter names in Model @phpstan-method callable types

[gr8man]

Description

Fixes PhpStorm docblock parsing errors (Expected: variable) on Model @phpstan-method annotations for when() and whenNot() methods by:

1. Adding explicit mixed type hint to $condition parameter (mixed $condition).
2. Specifying parameter names $builder and $value in the callable(...) signature.
3. Replacing (callable(...))|null with standard nullable type syntax ?callable(...).

Fixes #10443

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[paulbalandan]

This is still red on PHPStorm.

[paulbalandan]

And pls use the PR template moving forward.

[paulbalandan]

The issue is that PhpStorm cannot parse the parenthesis in callable:

Please use this fix instead:

diff --git a/system/Model.php b/system/Model.php
index ccade9cfb7..c6390298ab 100644
--- a/system/Model.php
+++ b/system/Model.php
@@ -40,6 +40,10 @@ use stdClass;
  *
  * @property-read BaseConnection $db
  *
+ * @phpstan-type WhenCallback callable(BaseBuilder, mixed): mixed
+ * @phpstan-type WhenDefaultCallback callable(BaseBuilder): mixed
+ * @phpstan-import-type row_array from BaseModel
+ *
  * @method $this groupBy($by, ?bool $escape = null)
  * @method $this groupEnd()
  * @method $this groupStart()
@@ -78,15 +82,11 @@ use stdClass;
  * @method $this selectMax(string $select = '', string $alias = '')
  * @method $this selectMin(string $select = '', string $alias = '')
  * @method $this selectSum(string $select = '', string $alias = '')
- * @method $this when($condition, callable $callback, ?callable $defaultCallback = null)
- * @method $this whenNot($condition, callable $callback, ?callable $defaultCallback = null)
+ * @method $this when($condition, WhenCallback $callback, ?WhenDefaultCallback $defaultCallback = null)
+ * @method $this whenNot($condition, WhenCallback $callback, ?WhenDefaultCallback $defaultCallback = null)
  * @method $this where($key, $value = null, ?bool $escape = null)
  * @method $this whereIn(?string $key = null, $values = null, ?bool $escape = null)
  * @method $this whereNotIn(?string $key = null, $values = null, ?bool $escape = null)
- *
- * @phpstan-method $this when($condition, callable(BaseBuilder, mixed): mixed $callback, (callable(BaseBuilder): mixed)|null $defaultCallback = null)
- * @phpstan-method $this whenNot($condition, callable(BaseBuilder, mixed): mixed $callback, (callable(BaseBuilder): mixed)|null $defaultCallback = null)
- * @phpstan-import-type row_array from BaseModel
  */
 class Model extends BaseModel
 {