refactor: replace empty()

kenjis · kenjis · commit 9a9da1426292 · 2024-06-22T15:10:51.000+09:00
diff --git a/phpstan-baseline.php b/phpstan-baseline.php
@@ -3106,7 +3106,7 @@
 $ignoreErrors[] = [
 	// identifier: empty.notAllowed
 	'message' => '#^Construct empty\\(\\) is not allowed\\. Use more strict comparison\\.$#',
-	'count' => 5,
+	'count' => 3,
 	'path' => __DIR__ . '/system/Database/OCI8/Connection.php',
 ];
 $ignoreErrors[] = [
diff --git a/system/Database/OCI8/Connection.php b/system/Database/OCI8/Connection.php
@@ -126,7 +126,7 @@ public function connect(bool $persistent = false)
 
         $func = $persistent ? 'oci_pconnect' : 'oci_connect';
 
-        return empty($this->charset)
+        return ($this->charset === '')
             ? $func($this->username, $this->password, $this->DSN)
             : $func($this->username, $this->password, $this->DSN, $this->charset);
     }

Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,7 @@ public function connect(bool $persistent = false)`
`126`	`126`
`127`	`127`	`$func = $persistent ? 'oci_pconnect' : 'oci_connect';`
`128`	`128`
`129`		`- return empty($this->charset)`
	`129`	`+ return ($this->charset === '')`
`130`	`130`	`? $func($this->username, $this->password, $this->DSN)`
`131`	`131`	`: $func($this->username, $this->password, $this->DSN, $this->charset);`
`132`	`132`	`}`