fix: if conditions to build DSN

kenjis · kenjis · commit 54b0441f5fb8 · 2024-06-22T15:10:51.000+09:00
diff --git a/system/Database/OCI8/Connection.php b/system/Database/OCI8/Connection.php
@@ -120,7 +120,7 @@ private function isValidDSN(): bool
      */
     public function connect(bool $persistent = false)
     {
-        if (empty($this->DSN) && ! $this->isValidDSN()) {
+        if ($this->DSN === null || $this->DSN === '' || ! $this->isValidDSN()) {
             $this->buildDSN();
         }
 

Original file line number	Diff line number	Diff line change
`@@ -120,7 +120,7 @@ private function isValidDSN(): bool`
`120`	`120`	`*/`
`121`	`121`	`public function connect(bool $persistent = false)`
`122`	`122`	`{`
`123`		`- if (empty($this->DSN) && ! $this->isValidDSN()) {`
	`123`	`+ if ($this->DSN === null \|\| $this->DSN === '' \|\| ! $this->isValidDSN()) {`
`124`	`124`	`$this->buildDSN();`
`125`	`125`	`}`
`126`	`126`