fix: update namespace handling in cluster resource reporter #964
+3
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change simplifies the RBAC configuration by removing the nonResourceURLs rules, which are not necessary for the functionality of the cluster and runtime event reporters.
…event reporters This change introduces the IS_NAMESPACED_RUNTIME variable in the environment configuration for both cluster and runtime event reporters. This variable is set to the value of .Values.global.runtime.singleNamespace, ensuring that the runtime context is correctly reflected in the environment settings.
codefresh-v2-pipelines
bot
force-pushed
the
CR-32335-fix-namesapced-runtime-roles
branch
from
f31fd7d to
49c2b7e
Compare
codefresh-v2-pipelines
bot
requested review from
a team,
chen-keinan,
dmaizel,
eti-codefresh and
scme0
as code owners
ATGardner
changed the title
ATGardner
force-pushed
the
CR-32335-fix-namesapced-runtime-roles
branch
from
49c2b7e to
21a9a0e
Compare
Contributor
Author
|
/e2e |
1 similar comment
Contributor
Author
|
/e2e |
dmaizel
approved these changes
Nov 30, 2025
shirtabachii
approved these changes
Nov 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #965
What
fix rbac and cluster-event-reporter when running in a namespaced runtime