Skip to content

Bug fixes to direct users to email verification before submitting testimony#2119

Open
J-C-L wants to merge 2 commits intocodeforboston:mainfrom
J-C-L:testimony-detail-page-bug-fix
Open

Bug fixes to direct users to email verification before submitting testimony#2119
J-C-L wants to merge 2 commits intocodeforboston:mainfrom
J-C-L:testimony-detail-page-bug-fix

Conversation

@J-C-L
Copy link
Copy Markdown
Collaborator

@J-C-L J-C-L commented May 6, 2026

Summary

Two bugfixes addressing issue #2057

  1. Added a check to the "Add Testimony" button on the Testimony Detail page so that users who have not verified their email will be asked to “verify email to add testimony”, and then led to their profile page upon clicking the button.
  2. Added a redirect from the Submit Testimony page to the Profile Page for users that are not email verified

Checklist

  • [ Yes ] On the frontend, I've made my strings translate-able.
  • [ N/A ] If I've added shared components, I've added a storybook story.
  • [ N/A ] I've made pages responsive and look good on mobile.
  • [N/A ] If I've added new Firestore queries, I've added any new required indexes to firestore.indexes.json (Please do not only create indexes through the Firebase Web UI, even though the error messages may reccommend it - indexes created this way may be obliterated by subsequent deploys)

Screenshots

VerifyEmailToAddTestimony

Steps to test/reproduce

A. Test for user without email verification:
1. Create a new user but do not verify their email.
2. Navigate to a particular testimony. Example
3. Confirm that button on the right says "Verify Your Email to Add Testimony for "
4. Click that button and confirm it takes you to the profile page where the verify account section is visible.
5. Paste a submit testimony page directly into the URL and confirm you are redirected to your profile page. Example:

B. Test for user with email verification (Behavior unchanged from current state. Confirming no regression):
1. Create a new user and verify their email.
2. Navigate to a particular testimony. Example
3. Confirm that button on the right says "Add Testimony for "
4. Click that button and confirm it takes you to the Sumit Testimony page.
5. Confirm that he Sumit Testimony page loads as expected.

C. Test for user not logged in (Behavior unchanged from current state. Confirming no regression):
1. Log out
2. Navigate to a particular testimony. Example
3. Confirm that button on the right says "Add Testimony for "
4. Click that button and confirm it takes you to the login / signup page.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
maple-dev Ready Ready Preview, Comment May 6, 2026 0:58am

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant