Bug fixes to direct users to email verification before submitting testimony#2119
Open
J-C-L wants to merge 2 commits intocodeforboston:mainfrom
Open
Bug fixes to direct users to email verification before submitting testimony#2119J-C-L wants to merge 2 commits intocodeforboston:mainfrom
J-C-L wants to merge 2 commits intocodeforboston:mainfrom
Conversation
… submitting testimony
…hat are not email verified
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two bugfixes addressing issue #2057
Checklist
firestore.indexes.json(Please do not only create indexes through the Firebase Web UI, even though the error messages may reccommend it - indexes created this way may be obliterated by subsequent deploys)Screenshots
Steps to test/reproduce
A. Test for user without email verification:
1. Create a new user but do not verify their email.
2. Navigate to a particular testimony. Example
3. Confirm that button on the right says "Verify Your Email to Add Testimony for "
4. Click that button and confirm it takes you to the profile page where the verify account section is visible.
5. Paste a submit testimony page directly into the URL and confirm you are redirected to your profile page. Example:
B. Test for user with email verification (Behavior unchanged from current state. Confirming no regression):
1. Create a new user and verify their email.
2. Navigate to a particular testimony. Example
3. Confirm that button on the right says "Add Testimony for "
4. Click that button and confirm it takes you to the Sumit Testimony page.
5. Confirm that he Sumit Testimony page loads as expected.
C. Test for user not logged in (Behavior unchanged from current state. Confirming no regression):
1. Log out
2. Navigate to a particular testimony. Example
3. Confirm that button on the right says "Add Testimony for "
4. Click that button and confirm it takes you to the login / signup page.