Storybook stories for phone verification modal and verify account section#2115
Open
J-C-L wants to merge 3 commits intocodeforboston:mainfrom
Open
Storybook stories for phone verification modal and verify account section#2115J-C-L wants to merge 3 commits intocodeforboston:mainfrom
J-C-L wants to merge 3 commits intocodeforboston:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow up to Commit 9dd240b for issue #2089.
This adds storybook stories for the phone verification modal (phone step, code step, and success step), the verify account section that will appear on the edit profile view profile pages when a user is logged in, and the view profile page.
Checklist
firestore.indexes.json(Please do not only create indexes through the Firebase Web UI, even though the error messages may reccommend it - indexes created this way may be obliterated by subsequent deploys)Steps to test/reproduce
Run storybook.
Visually inspect each of the 3 steps (phone step, code step, and success step).
a. Visually inspect the box.
b. Click on Resend link in the email section. You should see a "something went wrong" message because no user is logged in.
c. Click on Verify in the phone section and confirm that the verify phone modal comes up.
Confirm page looks as expected for viewing one's own profile. This should include the "verify account" section for a user that has not yet verified phone or email.
Confirm page looks as expected for viewing someone else's profile. This should not include the "verify account" section, or the settings/your testimonies/followed content buttons