fix: handle missing slug in upload-coverage command - #776
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue CLI-BN, where the
upload-coveragecommand would crash with an unhandledValueError: The provided slug is invalidif the--slugargument was not supplied by the user and could not be automatically resolved by a CI adapter.The root cause was that a
Nonevalue forslugwas passed toencode_slug(), which then raised aValueErrorwhenslug_with_subgroups_is_invalid(None)evaluated toTrue.The fix introduces an early validation check in the
upload_coveragecommand. IfslugisNoneor empty, aclick.ClickExceptionis now raised with a user-friendly message, guiding the user to provide the required--slug owner/repoargument.Fixes CLI-BN
This PR was automatically generated by Sentry. You can adjust this setting at any time.