Skip to content

fix: Prevent TypeError in GcovPlugin when scanning node_modules #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sentry wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Prevent TypeError in GcovPlugin when scanning node_modules #726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion codecov_cli/helpers/folder_searcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,12 @@ def _is_included(
multipart_include_regex: Optional[Pattern],
path: pathlib.Path,
):
return filename_include_regex.match(path.name) and (
try:
path_name = path.name
except TypeError:
logger.warning(f"Unable to determine name for path: {path}")
return False
return filename_include_regex.match(path_name) and (
multipart_include_regex is None
or multipart_include_regex.match(path.resolve().as_posix())
)
Expand Down
5 changes: 4 additions & 1 deletion codecov_cli/plugins/gcov.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,10 @@ def __init__(
):
self.executable = executable or "gcov"
self.extra_arguments = extra_arguments or []
self.folders_to_ignore = folders_to_ignore or []
default_folders_to_ignore = ["node_modules", ".git", "vendor"]
self.folders_to_ignore = list(
set(default_folders_to_ignore + (folders_to_ignore or []))
)
self.patterns_to_ignore = patterns_to_ignore or []
self.patterns_to_include = patterns_to_include or []
self.project_root = project_root or pathlib.Path(os.getcwd())
Expand Down
Loading