Skip to content

Fix Puppeteer grabAttributeFrom returning a CSSStyleDeclaration for style #5777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 2 commits into
base: 4.x
Choose a base branch
from
Open

Fix Puppeteer grabAttributeFrom returning a CSSStyleDeclaration for style #5777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ced822
Initial plan
Copilot Oct 31, 2026
12cee0e
Apply remaining changes
Copilot Oct 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/helper/Puppeteer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2271,7 +2271,7 @@ class Puppeteer extends Helper {
const els = await this._locate(locator)
const array = []
for (let index = 0; index < els.length; index++) {
const a = await this._evaluateHandeInContext((el, attr) => el[attr] || el.getAttribute(attr), els[index], attr)
const a = await this._evaluateHandeInContext((el, attr) => (attr === 'style' ? el.getAttribute(attr) : el[attr] || el.getAttribute(attr)), els[index], attr)
array.push(a)
}
return array
Expand Down
6 changes: 6 additions & 0 deletions test/helper/webapi.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1469,6 +1469,12 @@ export function tests() {
assert.equal(val, 'oldfag')
})

it('should grab full style attribute', async () => {
await I.amOnPage('/form/example1')
const style = await I.grabAttributeFrom('#LoginForm_username_em_', 'style')
assert.equal(style, 'display:none')
})

it('should grab attribute from element', async () => {
await I.amOnPage('/search')
const val = await I.grabAttributeFrom(
Expand Down
Loading