fix: make XPath relative in buildLocatorString for within() scope#5474
Open
mirao wants to merge 1 commit intocodeceptjs:4.xfrom
Open
fix: make XPath relative in buildLocatorString for within() scope#5474mirao wants to merge 1 commit intocodeceptjs:4.xfrom
mirao wants to merge 1 commit intocodeceptjs:4.xfrom
Conversation
…deceptjs#5473) Playwright's XPath engine auto-converts "//..." to ".//..." when searching within an element, but only when the selector starts with "/". Locator methods like at(), first(), last() wrap XPath in parentheses (e.g. "(//...)[position()=1]"), bypassing that auto-conversion and causing XPath to search from the document root instead of the within() scope. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildLocatorString()solocate().at(),.first(),.last()work correctly insidewithin()with Playwright helper//...to.//...when the root is not a Document, but only when the selector starts with/. Locator methods likeat()wrap XPath in parentheses (e.g.(//...)[position()=1]), bypassing that auto-conversion.before the first//that follows any leading parenthesesFixes #5473
Test plan
buildLocatorStringcoveringat(),first(),last(),at().find(), plain XPath, already-relative XPath, and CSS passthrough#seeAttributesOnElementsunrelated to this change)🤖 Generated with Claude Code