Skip to content

Conversation

@ahoehma
Copy link

@ahoehma ahoehma commented Aug 9, 2025

No description provided.

@ahoehma ahoehma requested a review from a team as a code owner August 9, 2025 11:56
@ahoehma
Copy link
Author

ahoehma commented Aug 10, 2025

Hmmm ... The de.codecentric.boot.admin.client.ClientServletApplicationTest hangs forever (in my fork build) ... Is this normal?

image

Locally its "working" ...

image

@ahoehma
Copy link
Author

ahoehma commented Aug 10, 2025

I found a major problem ... may you guys have an idea ...

Currently de.codecentric.boot.admin.client.config.SpringBootAdminClientRegistrationClientAutoConfigurationTest is failing for some of the defined "what kind of RegistrationClient is used" tests ... because de.codecentric.boot.admin.client.config.SpringBootAdminClientAutoConfiguration is mixing restclient and webclient and the bean-conditions which working with sb 3.5.x are no longer working because of the new splitting of the springboot dependencies ... may I'm wrong ...

image image

@ahoehma ahoehma marked this pull request as draft August 10, 2025 10:17
@ahoehma
Copy link
Author

ahoehma commented Aug 10, 2025

jolokia-support-spring is also not ready yet for spring-boot 4: jolokia/jolokia#866
I started a MR there as well: jolokia/jolokia#867

@SteKoe SteKoe force-pushed the feat/migrate-to-springboot-4 branch from c6403c2 to 13573fd Compare August 11, 2025 07:38
@SteKoe SteKoe changed the title Migration to springboot 4 feat(deps): Upgrade to Spring Boot 4 Aug 15, 2025
@SteKoe SteKoe changed the title feat(deps): Upgrade to Spring Boot 4 feat(deps): upgrade to Spring Boot 4 Aug 15, 2025
@SteKoe SteKoe mentioned this pull request Aug 20, 2025
@ahoehma
Copy link
Author

ahoehma commented Oct 3, 2025

I update the fork to M3 ... now some more new "incompatibilities" present ... all about jackson.

For example in de.codecentric.boot.admin.server.utils.jackson.EndpointMixinTest

image

The new org.springframework.boot.test.json.JacksonTester.initFields(Object, JsonMapper)

accept only tools.jackson.databind.json.JsonMapper from jackson-databind-3.0.0-rc9.

I can't find anything in spring's migration guide for this changes :-(

https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-4.0-Migration-Guide

SteKoe and others added 20 commits November 14, 2025 10:05
TODO: Fix Autoconfiguration for RegistrationClient
- I did "mvn install -DskipTests=true -nsu -Dcheckstyle.skip=false -pl '!spring-boot-admin-docs'"
- spring-boot-admin-docs doesn't build successfully no glue why
…re.MailSenderAutoConfiguration]

- some tests failing because of missing MailSenderAutoConfiguration
- adding spring-boot-starter-mail in test-scope
- the CountDownLatch.await should have a timeout too
…re.MailSenderAutoConfiguration]

- some tests failing because of missing MailSenderAutoConfiguration
- adding spring-boot-starter-mail in test-scope
- wee need both starters because of import of RestTemplateAutoConfiguration,
  RestClientAutoConfiguration and WebClientAutoConfiguration in SpringBootAdminClientAutoConfiguration
- locally (win 11, gitbash, eclipse) ClientServletApplicationTest not working,
  the --spring.jackson.property-naming-strategy=SNAKE_CASE is not used (no glue why)
  - in github build its working - why is this?
- locally SpringBootAdminClientRegistrationClientAutoConfigurationTest is also not
  working 100% - a lot of "wrong" RegistrationClient are created, doesn't matter
  which "builders" are in the spring context
  - in github build its working - why is this?
SteKoe and others added 29 commits November 28, 2025 15:16
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…c#4847)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…c#4850)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
….4.2 (codecentric#4849)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…edation under high load (codecentric#4784)

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ric#4854)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ric#4865)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…n to v2.20.0 (codecentric#4868)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…c#4870)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…n to v2.20.1 (codecentric#4871)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ric#4876)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@ahoehma ahoehma force-pushed the feat/migrate-to-springboot-4 branch from 4ccf0e6 to 4a96e55 Compare November 28, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants