Add uniqueness validation for contact email scoped to sponsor#2713
Merged
Conversation
mroderick
force-pushed
the
add-contact-uniqueness-validation
branch
from
July 16, 2026 09:06
3e626e8 to
614d21d
Compare
mroderick
marked this pull request as ready for review
July 16, 2026 09:11
KimberleyCook
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ActiveRecord::RecordNotUnique(PG::UniqueViolation) raised when a duplicate contact email is submitted for the same sponsor. The DB has a unique index on(email, sponsor_id), but there is no model-level validation, sovalid?passes andsaveblows up with a 500.Root cause: double-submit on the sponsor edit form — two POSTs arrive, both carrying the same new contact (no
id). First INSERT succeeds, second hits the unique constraint.https://app.rollbar.com/a/codebar-production/fix/item/codebar-production/705#detail
Fix
Added
validates :email, uniqueness: { scope: :sponsor_id }to Contact. Nowvalid?catches the duplicate before reaching the DB, and the controller re-renders the form with a validation error instead of a 500.Changes
app/models/contact.rb— add uniqueness validationspec/models/contact_spec.rb— new model spec for Contact validations