-
Notifications
You must be signed in to change notification settings - Fork 16
feat(deps_nix): Add rustler precompiled overrides to deps_nix #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Would you mind rebasing and resolving conflicts? Thanks for your contribution! |
|
sure |
refactor(deps_nix): nix formatting Nix formatting in template
3a8b66e to
3f9894c
Compare
|
just did that but the snippet concerning vega lite appeared to not just that... There is also a name of library mismatch. I do not know if it is very common, but the nif expects ex_vl_convert.so, not libex_vl_convert.so. It is possible to find a workaround using the proposed patch, but I suppose this might come from how build is organised UPD: I found this workaround makes the nif work postInstall = ''
ln -s libex_vl_convert.so $out/lib/ex_vl_convert.so
''; |
|
I don't understand. Is this PR ready, or is there an issue with it that requires a workaround? Or is the issue with the current main branch? |
|
The pr is ready, the problem is package specific as far as I understand it now |
|
hi! any next steps? |
|
I just need to get off my arse and re-read what this is about.
…-------- Original Message --------
On Saturday, 01/17/26 at 22:30 Maxim Kochurov ***@***.***> wrote:
ferrine left a comment [(code-supply/deps_nix#41)](#41 (comment))
hi! any next steps?
—
Reply to this email directly, [view it on GitHub](#41 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AABCTJLCACFZO6MCEAVU5BD4HKZY5AVCNFSM6AAAAACQYW5QAWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTONRUGQYTKMBVGY).
You are receiving this because you commented.Message ID: ***@***.***>
|
|
So the point of this is to fix vega_lite_convert? Shouldn't we fix it so that the package 'just works', rather than requiring the user to override? |
|
This PR provides a broader perspective rather than fixing a single package, it will help to tweak any rustler binding. To fix vega specifically we need to come up with how to choose the version for v8 package since each vega version might require its own |
|
I saw there is another approach too #20 (comment) |
|
TBH I've been focusing on making the latest versions of packages work and encouraging upgrades. I think it'll be a mammoth task to support older versions of every package. Adding support for overrides in general makes sense to me, but will wait to hear what others think. |
fix #20